Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAssembly WIP plus fix for edge case in decoding. #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krisselden
Copy link
Owner

No description provided.

@vlascik
Copy link

vlascik commented Oct 24, 2017

So does this help, how faster is it so far?
Btw, have you seen https://medium.com/@david.aurelio/medium-fast-source-map-generation-for-react-native-ea5549007c18 ? A write-up on how React got their sourcemap generation down from 3s to 0.5s. Seems like it could be useful.

@krisselden
Copy link
Owner Author

@vlascik there are benchmarks, the current js version goes from 5 seconds for source-map to .5 for the 15mb of mappings in that scala sourcemap example. The webassembly version didn't see much improvement for node 8 but on the nightly v8 integration it cut it down to ~250ms from 500ms.

Thanks for the article you can see if you look at the history of this project I'm aware of the allocation issues and how slow the Mozilla sourcemap library is. I have further notes for speeding up concat in a build pipeline and other ideas but just have had a limited amount of time.

@vlascik
Copy link

vlascik commented Oct 27, 2017

5s -> 250ms is pretty awesome, great job.
I just realized fast-sourcemap-concat still uses Mozilla's source-map for some reason... that's a shame, fixing sourcemaps could really help with Ember's rebuilds.
I'll take a look if I'd be able to change that, but I'm afraid getting up to speed on the subject won't be that trivial. Hope you'll find some spare cycles soon.

@Turbo87 Turbo87 mentioned this pull request Oct 27, 2017
@stefanpenner
Copy link
Collaborator

I'll take a look if I'd be able to change that, but I'm afraid getting up to speed on the subject won't be that trivial. Hope you'll find some spare cycles soon.

Ya the goal of this project is to eventually replace the one in broccoli-concat. If you have cycles to help, we would love the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants