Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strangely slow performance on files with long strings #14

Closed
Syampuuh opened this issue Apr 29, 2022 · 1 comment
Closed

Strangely slow performance on files with long strings #14

Syampuuh opened this issue Apr 29, 2022 · 1 comment

Comments

@Syampuuh
Copy link

Syampuuh commented Apr 29, 2022 •
edited
Loading

Despite speedy performance on other much larger files, minify-xml has been completely halting its work when trying to process files that, as far as I can tell as their common distinguishing factor anyway, have long strings within tags.
This file took about 15 minutes to process: https://pastebin.com/G4fGQ9DB

This file was sitting for something like 40 minutes before I noticed the halted progress and cancelled it: https://pastebin.com/3XMpZciC
kristian added a commit that referenced this issue May 16, 2022
@kristian
Improve replacing between brackets
566db90 
Also fix issue w/ catastrophic backtracking in DOCTYPE patterns (#14)
kristian added a commit that referenced this issue May 16, 2022
@kristian
Improve replacing between brackets
8345fbc 
Also fix issue w/ catastrophic backtracking in DOCTYPE patterns (#14)
@kristian
Copy link
Owner

I just released v3.4.0 with 8345fbc which should fix your issue. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristian @Syampuuh