Skip to content
This repository has been archived by the owner on Sep 3, 2018. It is now read-only.

rename ARKError #40

Closed
kristjank opened this issue Oct 5, 2017 · 0 comments
Closed

rename ARKError #40

kristjank opened this issue Oct 5, 2017 · 0 comments
Labels
to do

Comments

@kristjank
Copy link
Owner

Class name is misleading and also the ones that inherit it... it' looks...

Maybe a rename from ArkError - ArkResponseStatus? or something... as you also have success variable...
Then you have to align with ArkTransactionResponse - I think thouse two classes server same purpuose?

@sharkdev-j @dnovacik
@kristjank kristjank added the to do label Oct 5, 2017
@dnovacik dnovacik mentioned this issue Oct 5, 2017
Merged
kristjank pushed a commit that referenced this issue Oct 6, 2017
Merge pull request #41 from dnovacik/40-feature
be49f10 
rename ArkError to ArkResponseBase and refactor whole solution closes #40
kristjank pushed a commit that referenced this issue Jul 15, 2018
Merge pull request #40 from sharkdev-j/37-refactorvotefordelegate
70c585e 
made vote/unvote easier in controller
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kristjank