Skip to content
This repository has been archived by the owner on Sep 3, 2018. It is now read-only.

Improve account controller usability #9

Closed
ghost opened this issue Sep 24, 2017 · 1 comment · Fixed by #10
Closed

Improve account controller usability #9

ghost opened this issue Sep 24, 2017 · 1 comment · Fixed by #10
Labels
enhancement
Milestone
v0.8.0

Comments

@ghost
Copy link

ghost commented Sep 24, 2017

  1. Make private variables for passPhrase & secondPassPhrase
  2. return all account info to _account in constructor using AccountService.GetByAddress.
  3. Remove all passPhrase & secondPassPhrase parameters in all methods in AccountController. Replace with the _ variables
@kristjank kristjank added this to the v0.8.0 milestone Sep 24, 2017
@kristjank
Copy link
Owner

ok Agreed, nice suggestion

@ghost ghost mentioned this issue Sep 24, 2017
Merged
kristjank pushed a commit that referenced this issue Sep 24, 2017
Merge pull request #10 from sharkdev-j/9-feature
7019f6b 
Changes for enhancement #9. closes #9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Changes for enhancement #9.
1 participant
@kristjank