Ensure same order of stylesheets for built and non built environment #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be symetric with 'load' method which appends link element as last one (this ensures same stylesheets order for build and non build version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using build/amd-css dojo build plugin, stylesheets are inserted as first children of head.
But in non build environment they are appended as last children.
And if there are other style/link elements in head (static, not loaded by xstyle), they are in one case before xstyle elements, and in second one after them. And the order is significant when some rules have same 'strength'.
This commit changes the behavior, so also in build environment, stylesheets are appended as last children.