Time the watch operations for each iteration #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaenr
force-pushed
the
capture_operations_timing
branch
3 times, most recently
from
9aceb29
to
aa00cbf
Compare
|
Can one of the admins verify this patch? |
Closed
This commit adds support to time the operations like watching nodes, cluster operators, namespaces e.t.c and prints out the info after each iteration. This will help in understanding how long each operation is taking and act accordingly. It will be helpful in looking at how long cerberus takes to run the checks as wells as the impact on the timing when running it on a small scale vs large scale clusters. Eventually they can be exposed as metrics and act accordingly if higher latency is observed with Kube/OpenShift API.
chaitanyaenr
force-pushed
the
capture_operations_timing
branch
from
aa00cbf
to
d4bd98f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to time the operations like watching nodes,
cluster operators, namespaces e.t.c and prints out the info after
each iteration. This will help in understanding how long each operation
is taking and act accordingly.
It will be helpful in looking at how long cerberus takes to run the
checks as wells as the impact on the timing when running it on a small
scale vs large scale clusters. Eventually they can be exposed as metrics
and act accordingly if higher latency is observed with Kube/OpenShift API.