Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ci tests for all current scenario on push to main or ci_tests #21

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

paigerube14
Copy link
Collaborator

@paigerube14 paigerube14 commented Nov 1, 2021

Description

Adding in Ci tests for all current scenarios and pushes to quay when main gets updates

See https://github.com/cloud-bulldozer/kraken-hub/actions/runs/1408404101 for latest successful run

Fixes

#11

@paigerube14
Copy link
Collaborator Author

This would be instead of: #18

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, other than that LGTM.

@@ -0,0 +1,12 @@
test_application_outages.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,11 @@
test_application_outages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source CI/tests/common.sh

command="docker"
#command=$(command_to_run)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the commented lines? Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to leave in case someone wanted to run using podman. Could just add it to the README under the CI folder. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's okay to leave it in here.

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr chaitanyaenr merged commit 7afd52d into main Nov 2, 2021
This was referenced Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants