-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ci tests for all current scenario on push to main or ci_tests #21
Conversation
This would be instead of: #18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, other than that LGTM.
CI/tests/all_tests_sh
Outdated
@@ -0,0 +1,12 @@ | |||
test_application_outages.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this file in the CI? Maybe remove this in favor of https://github.com/cloud-bulldozer/kraken-hub/pull/21/files#diff-9ec331921529835bd3503a16b9295decde93f79c3bca6bca99ea95ffef885e43?
CI/tests/my_tests
Outdated
@@ -0,0 +1,11 @@ | |||
test_application_outages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using this file in the CI? Maybe remove this in favor of https://github.com/cloud-bulldozer/kraken-hub/pull/21/files#diff-9ec331921529835bd3503a16b9295decde93f79c3bca6bca99ea95ffef885e43?
source CI/tests/common.sh | ||
|
||
command="docker" | ||
#command=$(command_to_run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the commented lines? Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to leave in case someone wanted to run using podman. Could just add it to the README under the CI folder. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it's okay to leave it in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding in Ci tests for all current scenarios and pushes to quay when main gets updates
See https://github.com/cloud-bulldozer/kraken-hub/actions/runs/1408404101 for latest successful run
Fixes
#11