Adding oc, kubectl, version check to common run file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
changed the title
paigerube14
force-pushed
the
common_sh
branch
from
4556cb5
to
3377ab3
Compare
|
PTAL @chaitanyaenr when you get a chance Think I pushed all branches to https://quay.io/repository/prubenda/kraken-hub?tab=tags for testing |
paigerube14
changed the title
| @@ -0,0 +1,52 @@ | |||
| version: '3' | |||
There was a problem hiding this comment.
We might want instructions in the readme on how to build all the images, individual image of interest using docker-compose/podman-compose. Thoughts?
There was a problem hiding this comment.
yeh definitely think we should add a doc! I'll add
paigerube14
force-pushed
the
common_sh
branch
from
6e1eb42
to
85c083d
Compare
|
Added in docker-compose/podman-compose instructions on how to build your own images PTAL @chaitanyaenr |
chaitanyaenr
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is adding in common functions that all run.sh files will use
It'll verify the oc and kubectl cli are installed and print off the cluster version to verify the kubeconfig is properly defined
Fixes
#2