-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod docs #114
Pod docs #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anything else you can think to add here to clarify additions or edits to the configs? |
@paigerube14 The content looks good, it will definitely help users understand how to tweak or create new scenario configs. Maybe mention that the scenario configs can be loaded by specifying them in the main config under https://github.com/cloud-bulldozer/kraken/blob/master/config/config.yaml#L8. Think it might also help if we add something like "Refer to the scenarios supported ( add link ) to get started" as part of the installation page - https://github.com/cloud-bulldozer/kraken/blob/master/docs/installation.md. Thoughts? |
Can one of the admins verify this patch? |
Updated the doc to point to the kraken config line of how to add pod scenarios. I added the how to get started to the overall README, thoughts on having it there? I also noticed that the pod_scenarios were running twice because the run_kraken.py file called the pod_scenarios run twice so I took that out. Can have a separate PR for that if needed |
04bdc6c
to
cde639e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updated the pod killing scenario documentation to include specifics of how to edit/add a new scenario and what each section is looking for
Fixes
#112