Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all the litmus resources in a single namespace #148

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Run all the litmus resources in a single namespace #148

merged 1 commit into from
Sep 8, 2021

Conversation

chaitanyaenr
Copy link
Collaborator

Description

- This eases the usage and debuggability by running the fault injection pods in
  the same namespace as other resources of litmus. This will also ease the
  deletion process and ensure that there are no leftover objects on the cluster.

- This commit also enables users to use the same rbac template for all the litmus
  scenarios without having to pull in a specific one for each of the scenarios.

@paigerube14
Copy link
Collaborator

Would be nice to have a default cpu cores and nodes affected percentage in node_cpu_hog_engine similar to node_mem_engine

As well as a place holder for the node name

ex) '<node_name>'

paigerube14
paigerube14 reviewed Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@paigerube14 paigerube14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change service account to point to litmus-sa in both node_mem_engine.yaml and node_cpu_hog_engine.yaml

It is correct in node_io_engine.yaml

Once I edited this, it runs perfectly!

paigerube14
paigerube14 reviewed Sep 7, 2021
View reviewed changes
config/config.yaml
@@ -19,11 +20,11 @@ kraken:
- time_scenarios: # List of chaos time scenarios to load
- scenarios/time_scenarios_example.yml
- litmus_scenarios: # List of litmus scenarios to load
- - https://hub.litmuschaos.io/api/chaos/1.13.6?file=charts/generic/node-cpu-hog/rbac.yaml
- - https://raw.githubusercontent.com/cloud-bulldozer/kraken/master/scenarios/templates/litmus-rbac.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to point to the local copy of that file: scenarios/templates/litmus-rbac.yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, should we skip this change in favor of #149? Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! That works!

@paigerube14 paigerube14 mentioned this pull request Sep 7, 2021
Merged
@chaitanyaenr
Run all the litmus resources in a single namespace
85c78a6 
- This eases the usage and debuggability by running the fault injection pods in
  the same namespace as other resources of litmus. This will also ease the
  deletion process and ensure that there are no leftover objects on the cluster.

- This commit also enables users to use the same rbac template for all the litmus
  scenarios without having to pull in a specic one for each of the scenarios.
paigerube14
paigerube14 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr chaitanyaenr merged commit 5da0b25 into krkn-chaos:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paigerube14 paigerube14 paigerube14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaitanyaenr @paigerube14