This repository has been archived by the owner on Jul 10, 2022. It is now read-only.
Change content-type for Packages and Release files to text/plain #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dug deeper to discover this: 6c825e9 not sure what was the UTF-8 issue then. If you remember and can check/confirm if my PR does not introduce it back it would be great. Might be that |
|
Thanks! |
krobertson
added a commit
that referenced
this pull request
Jun 19, 2015
Change content-type for Packages and Release files to text/plain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve the issue #78 . I saw similar change for content-types were done previously in PR #28, not sure when it got lost. Also I have used
UTF-8insteadus-asciias ASCII is a sub-set of UTF-8 anyway, plus it might be that maintainer name can include some special characters (ą, ł, ę, etc.). But if I am missing something here I might set it to ASCII. I have tested in on S3 bucket and works as expected (files display in the browser instead of being downloaded).