Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Add locking support #89

Merged
merged 2 commits into from
Dec 17, 2015
Merged

Add locking support #89

merged 2 commits into from
Dec 17, 2015

Conversation

alexmreis
Copy link
Contributor

Implemented locking mechanism to prevent simultaneous updates from corrupting index. It is used optionally with the -l option.

Previously if 2 users were to update the repository in S3 at the same time, one of the packages would end up missing from Packages.gz and Release.

I've tried to follow the existing code as closely as possible, and added MiniTest specs for the extra code.

@alexmreis
Copy link
Contributor Author

BTW eventual consistency is not a problem unless you use the US Standard region. See http://shlomoswidler.com/2009/12/read-after-write-consistency-in-amazon.html

krobertson added a commit that referenced this pull request Dec 17, 2015
@krobertson krobertson merged commit 29da59c into krobertson:master Dec 17, 2015
@jjshoe
Copy link
Contributor

jjshoe commented Feb 10, 2016

@krobertson - Any chance of releasing a new gem with this option included?

@jjshoe
Copy link
Contributor

jjshoe commented Feb 10, 2016

Other item worth noting, README.md would need to be updated at that time showing the -l option. Happy to do a PR for that work if it'll make you more willing to release a new gem.

@jjshoe
Copy link
Contributor

jjshoe commented Feb 10, 2016

@krobertson - Scratch that, hold off on doing a release. Found a pretty critical bug in locking. Will make an issue shortly, and tag @alexmreis on it.

@alexmreis
Copy link
Contributor Author

Curious as to what the issue is, we've been using the patched version in a
CI environment since last October without any major issues.

On Wed, Feb 10, 2016 at 5:35 PM, jjshoe notifications@github.com wrote:

@krobertson https://github.com/krobertson - Scratch that, hold off on
doing a release. Found a pretty critical bug in locking. Will make an issue
shortly, and tag @alexmreis https://github.com/alexmreis on it.


Reply to this email directly or view it on GitHub
#89 (comment).

@jjshoe
Copy link
Contributor

jjshoe commented Feb 10, 2016

#97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants