Fix query execution lock-up for large frames. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `send_frame` function did use `write` method to send out frame data. The method actually writes just a portion of the data provided (usually first 16K). The rest was not written and got lost. That caused Cassandra node peer send no reply waiting for more frame data, which in turn led to `send_frame` hanging infinitely. The `write_all` method has to be used instead.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send_framefunction did usewritemethod to send outframe data. The method actually writes just a portion of the data provided
(usually first 16K). The rest was not written and got lost.
That caused Cassandra node peer send no reply waiting for more frame data,
which in turn led to
send_framehanging infinitely.The
write_allmethod has to be used instead.