Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout for the app #5

Open
krritik opened this issue Nov 29, 2019 · 15 comments
Open

Improve layout for the app #5

krritik opened this issue Nov 29, 2019 · 15 comments
Labels

Comments

@krritik
Copy link
Owner

krritik commented Nov 29, 2019

Currently the frontend is written only in css and html and is very basic. So improve the layout and add features like "Adjusting your websites to fit all types of resolution" and "navigation bar"

@Sahilbabani
Copy link
Contributor

i woulld love to do improve layout. please assign it to me.

@krritik
Copy link
Owner Author

krritik commented Dec 7, 2019

Cool, You can take the issue. But assigning means others will not be able to work on it. I can assign you, once you start working on it and have a WIP( work in progress ) pr and comment here a proposed solution.

@Sahilbabani
Copy link
Contributor

addning bootstrap files for responsive website and future implementation

@krritik
Copy link
Owner Author

krritik commented Dec 7, 2019

ok, I will assign you after a few more commits and do not worry, I will not assign it to anyone else. So work on it.

@Sahilbabani
Copy link
Contributor

thanks

@Sahilbabani
Copy link
Contributor

layout of home,login,signup page improved in pr-25

@Sahilbabani
Copy link
Contributor

pr #25

@krritik
Copy link
Owner Author

krritik commented Dec 10, 2019

@Sahilbabani
is it complete?

@Sahilbabani
Copy link
Contributor

Sahilbabani commented Dec 10, 2019 via email

@Sahilbabani
Copy link
Contributor

[] -User ,home,booking pages layput improved
[] -footer position corrected and added data in it
in pr #25

@krritik
Copy link
Owner Author

krritik commented Dec 15, 2019

Few changes are done, there is still a lot of scope for improvement like refactor of code (currently the header-footer code is written in all Html files, which can be created as separated template and just can be called in every template), still, it looks a lot of plain text. So, you can add any changes to improvement. If you have any doubts, comment here your ideas and queries

@krritik
Copy link
Owner Author

krritik commented Dec 15, 2019

I unassigned this, So now this is open for all to work.

@Suchana34
Copy link
Contributor

I am working on it. It is getting delayed due to my exams.

@krritik
Copy link
Owner Author

krritik commented Dec 17, 2019

Sure, you can send a working PR and a deadlinr for it

@Suchana34
Copy link
Contributor

I have completed almost. Some changes are left.

@krritik krritik mentioned this issue Jan 1, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants