Adds constants for each api version in kruize #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecommendation SO to have specific version of API rather than having the kruize object version Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
|
@bharathappali Also the docs all need to be updated to indicate the version change |
|
@bharathappali please also take a look at the JSONs / csvs in https://github.com/kruize/kruize-demos/tree/main/remote_monitoring_demo |
Will Raise the PR for the demo to be updated |
Signed-off-by: bharathappali <abharath@redhat.com>
Done. |
dinogun
reviewed
Nov 3, 2023
Raised a PR in Kruize-Demos repo kruize/kruize-demos#67 |
Signed-off-by: bharathappali <abharath@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the list recommendation Service Object to have specific version of API rather than having the kruize object version.
Fixes #1019