-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide api call to Stop experiment #57
Conversation
exception bug
…ondition on access to HpoService.experiments
@johnaohara Thank you for adding this, should make it easier for scripts to integrate HPO into workflows thanks to this feature. Just one comment, can you update the API doc for the new API |
@dinogun np, I will update the API doc |
Signed-off-by: John OHara <johara@redhat.com>
@dinogun I have updated the API Doc, and modified the response code to be consistent with the other POST commands. Quick question, is there a reason that the rest api's return |
…r issues for tests to work with stop experiment
@johnaohara Yes, that was convenient for us when HPO was part of Autotune and returning specific error codes. This needs to be changed going forward. |
@chandrams Are you done with your test changes? |
@dino - Yes, I 'm done with the test changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are use cases that require stopping an already running experiment. This PR provides REST & gRPC endpoints to allow users to stop a running experiment.
The PR includes sanity checks for remove removing running tests.
One commit that is not directly related to the main functionality of the PR is some changes to speed up running the test suite. Running the full testsuite went from 2562 seconds to 107 seconds on my machine, and allowed me to find a couple of race/locking issues. If it is deemed appropriate to separate out that change, I can revert that commit in this PR and open a separate PR