Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a MacOS bundle #100

Merged
merged 18 commits into from
Jul 4, 2023
Merged

Create a MacOS bundle #100

merged 18 commits into from
Jul 4, 2023

Conversation

MStraeten
Copy link
Contributor

icns format is needed to create an macOS app package

@krupkat krupkat changed the title add icns file for macOS package Create a MacOS bundle Jun 16, 2023
@krupkat
Copy link
Owner

krupkat commented Jun 16, 2023

Thanks a lot!

I made a few small changes and moved the new files to /misc/build/macos. Hopefully I didn't break the script, I'll merge it later today.

I'll leave the macports libSDL path as is - if there is a brew user who would like to help fix the script, please feel free to send a PR. The script could later be updated to use otool for finding the library paths, so it keeps working with different library versions.

@MStraeten
Copy link
Contributor Author

the script may need some further tweaks -depending on feedback on the prebuild package announced on pixls.us
maybe there're remaining dependencies to my local environment that need be taken into account.

@krupkat
Copy link
Owner

krupkat commented Jun 19, 2023

Very cool, thanks!
I'll try adding the bundle command to the CI.

If it works I can also add it to https://github.com/krupkat/xpano-release-builder/, so that the bundles are uploaded automatically to each release with a checksum. It would be x86 so far only, but it is probably doable to cross-build to arm later.

edit:
it seems to be working with brew based install on the CI runner, I just had to do this change: b36955c, because the build directories are not cached there

@krupkat
Copy link
Owner

krupkat commented Jun 19, 2023

when I used "set -e" to exit on error, the script errors out when iterating over an empty list

@krupkat krupkat merged commit 048441a into krupkat:main Jul 4, 2023
@krupkat
Copy link
Owner

krupkat commented Jul 4, 2023

I added the bundle build to the release builder (build job), the new release already has the built files (https://github.com/krupkat/xpano/releases/tag/v0.16.0).

As with the windows build, user can verify the checksum in the github build log.

Maybe some patches will be needed and there is still no m1 support. Seems that Github will provide m1 runners by end of year (github/roadmap#528).

Thanks for your help! @MStraeten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants