Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#51 bug report window #54

Merged
merged 28 commits into from
Oct 2, 2022
Merged

#51 bug report window #54

merged 28 commits into from
Oct 2, 2022

Conversation

poshi1865
Copy link
Contributor

Please review and let me know, thank you!

krupkat
krupkat requested changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@krupkat krupkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I tested the code and it works great!

The changes I requested are mostly minor, except the change to how the log path value is passed, please take a look at that and again feel free to clarify anything.

.gitignore Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.h Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.h Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.h Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
xpano/gui/panels/sidebar.cc Outdated Show resolved Hide resolved
xpano/log/logger.cc Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
@krupkat
Copy link
Owner

krupkat commented Oct 2, 2022

Please also merge the latest commit from the main branch (7df0749) to fix some of the workflows.

Seems there was a recent update to the runner images (https://github.com/actions/runner-images) that broke my ubuntu workflows.

@krupkat
Copy link
Owner

krupkat commented Oct 2, 2022

To pass the code formatting workflow, please run clang-format (check https://github.com/krupkat/xpano/blob/main/CONTRIBUTING.md).

@poshi1865
Copy link
Contributor Author

I think all the requested changes have been done. Please have a look and let me know. Thank you!

krupkat
krupkat requested changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@krupkat krupkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Please have a look at the last few issues.

xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
xpano/log/logger.cc Outdated Show resolved Hide resolved
xpano/gui/panels/bugreport_pane.cc Outdated Show resolved Hide resolved
xpano/log/logger.h Outdated Show resolved Hide resolved
@poshi1865
Copy link
Contributor Author

Done! Please review, thank you.

krupkat
krupkat previously approved these changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@krupkat krupkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I'll merge this once you resolve the final comment.

@poshi1865
Copy link
Contributor Author

Done

@krupkat krupkat merged commit 2cbaeac into krupkat:main Oct 2, 2022
@krupkat krupkat linked an issue Oct 3, 2022 that may be closed by this pull request
Bug report window #51
Closed
@krupkat krupkat mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krupkat krupkat krupkat approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report window
2 participants
@poshi1865 @krupkat