Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Is Invisible toggle does not function until players reload the page #1262

Closed
rexy712 opened this issue Apr 17, 2023 · 3 comments · Fixed by #1263
Closed

[BUG] Is Invisible toggle does not function until players reload the page #1262

rexy712 opened this issue Apr 17, 2023 · 3 comments · Fixed by #1263

Comments

@rexy712
Copy link
Contributor

rexy712 commented Apr 17, 2023

Describe the bug
The 'Is invisible' toggle for shapes only makes the shape invisible after reloading the page. It also does not make things become visible when unchecking the box until a page reload.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Basic Token
  2. Check the box in shape properties > Is invisible
  3. Players can still see the shape.
  4. Have players reload the page. They can not see the shape anymore.

Expected behavior
The Is invisible toggle should take effect when enabling/disabling rather than after a reload.

Screenshots

GM on left, normal player on right.

invisible-bug.mp4

Desktop:

  • OS: gentoo linux
  • Browser: firefox 111.0.1, ungoogled-chromium 112.0.5615.49
  • Version: dev branch commit 90fb740
@Kruptein
Copy link
Owner

This is very funny timing wise, because this exact bug happened in a game session I played in this weekend as well.

We also "resolved" it by refreshing, but I hadn't looked into what caused it.
So thanks for logging this, seems like the message is not getting passed along to active connections.

@Kruptein
Copy link
Owner

Also sorry if it ruined something :C given that it relates to invisible stuff

@rexy712
Copy link
Contributor Author

rexy712 commented Apr 17, 2023

No worries! I noticed it when my creature was supposed to be invisible and the players still knew where it was. I just started moving things to the DM layer to make them invisible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants