Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add player's mug shot to the auto complete #33

Closed
kruser opened this issue Feb 19, 2014 · 1 comment
Closed

Add player's mug shot to the auto complete #33

kruser opened this issue Feb 19, 2014 · 1 comment
Assignees
@kruser
Labels
enhancement

Comments

@kruser
Copy link
Owner

kruser commented Feb 19, 2014

Only for medium screens or bigger (aka, not mobile), we should add the players mug shot next to their name in the typeahead. This will allow users to distinguish players easier.

For example, this is what it looks like now. Notice if two players have similar names you have to guess.
image
@kruser kruser self-assigned this Feb 21, 2014
@kruser kruser closed this as completed in e157cbc Feb 21, 2014
kruser added a commit that referenced this issue Feb 21, 2014
@kruser
#33: use ng-src so we can use err-src directive as well. Duplicate
3891d6a 
ng-src with src for sharing purposes, as we want the URL of the img to
be available to plain old HTTP GETs
kruser added a commit that referenced this issue Feb 21, 2014
@kruser
fixed #33: move the path to the default-avatar.png image over to
80b9b39 
javascript as usemin is cool with it there
@kruser
Copy link
Owner Author

kruser commented Feb 21, 2014

This feature is now live on http://pitchfx.org.

image

@kruser kruser mentioned this issue Feb 21, 2014
Closed
@albertlyu albertlyu mentioned this issue Feb 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kruser kruser

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kruser