-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whiff % is showing 0% for all pitches #59
Comments
Looks like pitchStats.js was missing:
I'm not sure why. I'll investigate. I'm guessing I didn't have an updated local repo when I submitted my pull request. |
See commit 5e0f497 for the last time whiffs were being aggregated. pitchfx-site/app/app/scripts/controllers/pitchStats.js Lines 428 to 440 in 5e0f497
When ec62105 was pushed to master, the whiff stats were wiped out. I believe the intention was to remove the I believe the fix would be to add the following to L330-L333 at https://github.com/kruser/pitchfx-site/blob/master/app/app/scripts/controllers/pitchStats.js#L330-L333:
I will submit a pull request with these changes later today, for @kruser's review. |
deploying to site now. I only see you on the site @albertlyu so it's safe to deploy. FYI, if you don't want to show up on my Google Analytics you can always opt-out on Chrome. That's what I do. |
Ughh
The text was updated successfully, but these errors were encountered: