-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): introduce the openapi generated client in the next package #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor tweaks to the CI workflows are needed, and I have a question about the bundled OpenAPI schema. Overall looks good and promising though :)
next/katapult-openapi.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any script and/or Make target that can update this file from the production URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added make targets for getting the schema from the url and for running the generate script
5324a73
to
d50cc3b
Compare
Code Climate has analyzed commit 4efa020 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
Now available in
github.com/krystal/go-katapult/next
is a complete client for the katapult API.This is generated from the openapi spec.
For now this includes a docker image and a shell script for the build command.
Note
This bumps the following things :
v1.20
v1.56
v4
v5
v4
v5
goconst
has been disabled in test files.a few changes have been made across the project to remove usage of
io/ioutil
Closes #150