Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elf loading #90

Merged
merged 6 commits into from
May 7, 2022
Merged

Elf loading #90

merged 6 commits into from
May 7, 2022

Conversation

Skallwar
Copy link
Collaborator

@Skallwar Skallwar commented Feb 7, 2022

This PR aims to add elf loading support. This way the kernel would become "useful".

@Skallwar Skallwar force-pushed the elf_loader branch 2 times, most recently from 455730f to 2f95e30 Compare February 7, 2022 19:28
@Skallwar Skallwar requested review from n1tram1 and CohenArthur and removed request for n1tram1 February 7, 2022 21:19
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to testing it! :D Nice job!

src/executable/elf.rs Outdated Show resolved Hide resolved
@Skallwar Skallwar marked this pull request as draft February 8, 2022 10:35
@Skallwar
Copy link
Collaborator Author

Skallwar commented Feb 8, 2022

My bad this is still a draft for now since I can't get pagination to work correctly

@Skallwar
Copy link
Collaborator Author

I will create a real test instead of loading from main and we should be good 2 go

@Skallwar Skallwar marked this pull request as ready for review March 20, 2022 11:13
@Skallwar Skallwar requested review from CohenArthur and n1tram1 and removed request for n1tram1 March 20, 2022 11:13
src/arch/mod.rs Outdated Show resolved Hide resolved
@Skallwar Skallwar force-pushed the elf_loader branch 2 times, most recently from b153bdc to 0e9747f Compare March 20, 2022 19:44
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🔥

@Skallwar Skallwar requested review from n1tram1 and removed request for n1tram1 April 8, 2022 14:05
Copy link
Collaborator

@n1tram1 n1tram1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smile/dummy_elf: shouldn't we not push the binaries and instead provide a makefile to build them ?

Great work on test cases, we can only be going to the moon now 🚀

Finally some elfs 👺

src/executable/elf.rs Show resolved Hide resolved
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta tu Pull Request

fixtures/Makefile Outdated Show resolved Hide resolved
@Skallwar Skallwar requested a review from n1tram1 May 1, 2022 15:41
We are now able to read and load a static elf file from raw bytes. We are
allocating and mapping pages then copying content to the physical address
specified in the executable.
@Skallwar Skallwar merged commit 2142f64 into main May 7, 2022
@Skallwar Skallwar deleted the elf_loader branch May 7, 2022 15:13
@Skallwar Skallwar mentioned this pull request May 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants