Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mm with value objects for phys and virt addresses #93

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

n1tram1
Copy link
Collaborator

@n1tram1 n1tram1 commented Feb 20, 2022

  • refactor(mm): use value objects for phys and virt addresses

Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@n1tram1
Copy link
Collaborator Author

n1tram1 commented Feb 20, 2022

I refactored to implement conversions for PAddr/VAddr.
I'm not sure this is the best in terms of better type safety.

@CohenArthur could you have a second look ? I'm really not sure about putting .from() and .into() everywhere...

@n1tram1 n1tram1 changed the title refactor(mm): use value objects for phys and virt addresses Refactor mm with value objects for phys and virt addresses Feb 20, 2022
@n1tram1 n1tram1 force-pushed the refactor-mm-with-value-objects branch from c9aebab to 4299631 Compare February 21, 2022 08:51
@n1tram1 n1tram1 merged commit 06683c5 into main Feb 21, 2022
@n1tram1 n1tram1 deleted the refactor-mm-with-value-objects branch February 21, 2022 14:06
@Skallwar Skallwar mentioned this pull request May 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants