Add gitshelf as a format and fetch certain repos #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: b3a07b70-e702-11e8-87c2-ebfa2f2e9d99 |
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 9900ba40-e703-11e8-87c2-ebfa2f2e9d99 |
kx-chen
reviewed
Nov 13, 2018
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 981416b0-e70b-11e8-87c2-ebfa2f2e9d99 |
ksdme
requested changes
Nov 13, 2018
There was a problem hiding this comment.
- This PR should not close Manage a machine consumable list of all org repositories #6, please fix your commit message.
- I do not think we need another class of classes called decoders, I think you should rather rename the Encoder classes we have to be more general and then add a decoder method it can implement.
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: baec6ef0-e7a4-11e8-ad5c-f14c74a66e2e |
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 934bab30-e7a5-11e8-ad5c-f14c74a66e2e |
kx-chen
reviewed
Nov 15, 2018
ksdme
requested changes
Nov 15, 2018
Travis tests have failedHey @CLiu13, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 4e8c0b50-eaae-11e8-b26b-2fe956a0f750 |
This adds support for gitshelf as a format for a list of repositories. This also adds support for fetching only repos that are listed in a list of repositories, as specified by --import-repos and --format. Closes ksdme#29
ksdme
requested changes
Nov 19, 2018
| 'repo': url, | ||
| 'rev': 'master'} | ||
|
|
||
| def decode_repo_list(self, file_name): |
There was a problem hiding this comment.
decode_repo_list here handles reading from the files by itself whereas encodind doesn't. I think you should have encode method return a String of encoded data in whichever format it likes like JSON, YAML etc and likewise decode method should take a string and yield results.
| with open(file_name, 'r') as file: | ||
| yml_data = yaml.load(file) | ||
| for repo in yml_data['sources']: | ||
| yield [repo['name'], repo['repo']] |
| self._status_provider = [] | ||
| for i in enumerate(self.StatusProvider): | ||
| self._status_provider.append(self.StatusProvider[i[0]](self._group)) | ||
|
|
||
| self._sync = sync | ||
| if sync: |
| if sync: | ||
| self._token = GitHubToken(token) | ||
| self._org = GitHubOrganization(self._token, self._group) | ||
|
|
There was a problem hiding this comment.
Maybe something like
Suggested change
| else: | |
| self._nosync_repositories = kargs['repositories'] |
|
|
||
| @property | ||
| def repositories(self): | ||
| return self._org.repositories | ||
| return [repo.web_url for repo in self._org.repositories] |
There was a problem hiding this comment.
Please notice that if sync is False, this method will fail. We need an alternate build process for these classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for gitshelf as a format for a list
of repositories. This also adds support for fetching
only repos that are listed in a list of repositories,
as specified by --import-repos and --format.
Closes #6 and #29