Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add release tag workflow #7

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Oct 4, 2021

Motivation

We want version tagged docker images to be pushed to DockerHub when a new release is tagged in GitHub.

Modifications

Adjusted the workflow file to also test, build, and push the image on tags.

Result

Tagged image versions on DockerHub.

Copy link

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chinhuang007, pvaneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pvaneck
Copy link
Member Author

pvaneck commented Oct 4, 2021

/hold

@pvaneck
Copy link
Member Author

pvaneck commented Oct 4, 2021

/unhold

@pvaneck pvaneck merged commit 96f351c into kserve:main Oct 4, 2021
@pvaneck pvaneck deleted the release-process branch October 4, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants