[mwa-fix-unit-tests] Fix MWA's unit tests and create a GH action that runs the tests on each change of the frontend code #65
Conversation
elenzio9
force-pushed
the
feature-elena-mwa-unit-tests
branch
from
a6ab74d
to
6eedeb4
Compare
There was a problem hiding this comment.
Thank you @elenzio9 , introducing a COMMIT file is a great initiative! The tests run successfully and the WA works as expected as well.
/lgtm
cc @kimwnasptd
|
/approve |
|
looks like the bot is stuck again /lgtm |
|
/hold |
|
@elenzio9 looks like there are some conflicts. Could you rebase on top of the latest master? |
Update material-icons package to be consistent with the common library's one. Signed-off-by: Elena Zioga <elena@arrikto.com>
Fix broken unit tests. Signed-off-by: Elena Zioga <elena@arrikto.com>
Introduce COMMIT file that contains the commit where MWA needs to checkout inside Kubeflow's common code in order to be built. This file was integrated in the following places as well, thus a developer may only update one file each time we neeed to checkout to a newer commit. - Dockerfile - README.md Signed-off-by: Elena Zioga <elena@arrikto.com>
Introduce a Github action to run unit tests. This action is triggered upon PRs including changes inside the MWA frontend directory. Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-mwa-unit-tests
branch
from
6eedeb4
to
4acafc0
Compare
Just rebased! |
|
Thanks! /lgtm |
|
/hold |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR:
COMMITfile for building MWA