Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken 404-page: rewrite site_url #70

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Fix broken 404-page: rewrite site_url #70

merged 1 commit into from
Dec 29, 2021

Conversation

Shunpoco
Copy link
Contributor

Fixes #69

Proposed Changes

  • Rewrite site_url from https://kserve.io/docs to https://kserve.io/website

@netlify
Copy link

netlify bot commented Dec 29, 2021 •
edited

✔️ Deploy Preview for elastic-nobel-0aef7a ready!

🔨 Explore the source changes: be00760

🔍 Inspect the deploy log: https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/61cc6076d82e830007089823

😎 Browse the preview: https://deploy-preview-70--elastic-nobel-0aef7a.netlify.app

@Shunpoco
Copy link
Contributor Author

Shunpoco commented Dec 29, 2021 •
edited

Ref: This is my forked GitHub-pages which I set site_url with suffix /website.
We can see 404-page properly.

@yuzisun
Copy link
Member

yuzisun commented Dec 29, 2021

thanks @Shunpoco ! Can you help sign off the commit following the instruction ?

@Shunpoco
Fix site_url: /docs to /website
be00760 
Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
@Shunpoco
Copy link
Contributor Author

@yuzisun
Now I signed off!

@yuzisun
Copy link
Member

yuzisun commented Dec 29, 2021

Thanks for the fix!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shunpoco, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 6eaf323 into kserve:main Dec 29, 2021
@Shunpoco Shunpoco deleted the fix-404-broken branch December 29, 2021 13:52
@Shunpoco Shunpoco mentioned this pull request Dec 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theofpa theofpa Awaiting requested review from theofpa

@yuzisun yuzisun Awaiting requested review from yuzisun

Assignees

@yuzisun yuzisun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404-page is broken
3 participants
@Shunpoco @yuzisun @kserve-oss-bot