Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaks? #501

Closed
posguy99 opened this issue Jul 30, 2022 · 1 comment
Closed

Leaks? #501

posguy99 opened this issue Jul 30, 2022 · 1 comment
Labels
regressfail Regression test failure

Comments

@posguy99
Copy link

Still collecting spurious regression test failures? These come and go and come again. Below is from @f8645c4a on Debian Linux, they do not occur on macOS.

test leaks begins at 2022-07-30+16:31:56
...
	leaks.sh[371]: FAIL: clear hash table (hash -r) in subshell: leaked approx 576 KiB after 16384 iterations
...
test leaks failed at 2022-07-30+16:31:59 with exit code 1 [ 36 tests 1 error ]

test leaks(C.UTF-8) begins at 2022-07-30+16:31:59
...
test leaks(C.UTF-8) passed at 2022-07-30+16:32:03 [ 36 tests 0 errors ]

test leaks(shcomp) begins at 2022-07-30+16:32:03
...
	shcomp-leaks.ksh[371]: FAIL: clear hash table (hash -r) in subshell: leaked approx 612 KiB after 16384 iterations
...
test leaks(shcomp) failed at 2022-07-30+16:32:06 with exit code 1 [ 36 tests 1 error ]
@posguy99
Copy link
Author

Do not occur on my Kali VM, or my Mint VM, or my Ubuntu VM. Go figure.

@McDutchie McDutchie added the regressfail Regression test failure label Jul 31, 2022
McDutchie added a commit that referenced this issue Jul 31, 2022
@McDutchie
tests/leaks.sh: quadruple maximum number of test iterations
b07d7b2 
There were still intermittent leak test failures on Debian.
They're clearly spurious as a different test fails each time.

My testing on a Debian 11.4.0 VM showed that it takes not a
doubling, but a quadrupling of the maximum number of test
iterations (from 16384==2**14 to 65536==2**16) for that system's
memory state to stabilise enough to avoid spurious test failurese.

Resolves: #501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regressfail Regression test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@posguy99 @McDutchie