Fix a crash when kill %% and kill %+ are run
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ksh was trying to use the `pw` variable as a valid pointer even when it was NULL. This is fixed by doing the error check for `pw` before doing anything else in `job_kill`. This bugfix is from Red Hat: https://git.centos.org/rpms/ksh/blob/44e0a643a93492b1f6beebbf6ffcfd453d9ab8f2/f/SOURCES/ksh-20130214-fixkill.patch Fixes ksh93#34
McDutchie
pushed a commit
that referenced
this pull request
Jun 22, 2020
Ksh was trying to use the 'pw' variable as a valid pointer even when it was NULL. This is fixed by doing the error check for 'pw' before doing anything else in 'job_kill'. This bugfix is from Red Hat: https://git.centos.org/rpms/ksh/blob/44e0a643a93492b1f6beebbf6ffcfd453d9ab8f2/f/SOURCES/ksh-20130214-fixkill.patch Fixes #34
McDutchie
added a commit
that referenced
this pull request
Jul 22, 2020
This applies ksh93-jobs.dif from OpenSUSE. Source: https://build.opensuse.org/package/show/openSUSE:Leap:42.3:Update/ksh src/cmd/ksh93/sh/jobs.c: - jog_init(): Save errno in case close(JOBTTY) fails. If cause of failure was interruption by a signal (EINTR), repeat close. - job_kill(): Replace Red Hat fix for #35 with nicer OpenSUSE fix that doesn't add a goto before declaring variables. Re: ff358f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ksh was trying to use the
pwvariable as a valid pointer even when it was set toNULL, which is what caused thekillandstopcommands to crash when given an invalid job. This is fixed by doing the error check forpwbefore doing anything else injob_kill.This bugfix is from Red Hat:
https://git.centos.org/rpms/ksh/blob/44e0a643a93492b1f6beebbf6ffcfd453d9ab8f2/f/SOURCES/ksh-20130214-fixkill.patch