Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in the documentation and other minor issues #42

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

JohnoKing
Copy link

@JohnoKing JohnoKing commented Jun 25, 2020

Somewhat notable changes in this pull request:

@McDutchie
Copy link

I think the Red Hat patch is wrong. This is what happens on my system:

$ ksh
$ echo $-
imsBE
$ sleep 30 &
[1]	36447
$ kill -s INT "$!"
[1] +                          sleep 30 &
$ kill -s INT "$!"
kill: 36447: no such process
$ set +o monitor
$ sleep 30 &
[1]	36448
$ kill -s INT "$!"
$ kill -s INT "$!"
$ kill -s QUIT "$!"
$ kill -s QUIT "$!"
$ 

I think that shows that SIGINT and SIGQUIT are indeed ignored when the -m/-o monitor option is not active, as the original text says.

@JohnoKing
Copy link
Author

JohnoKing commented Jun 25, 2020

Red Hat's patch has been reverted. rhbz#1100215 and rhbz#1019334 may be worth looking into due to their connection to that patch.

Edit: The force-push has now updated the pull request.

Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5 has been
  applied to the ksh man page.
- A few fixes from att/ast@5e747cfb have been applied to the ksh
  man page.
- The man page fixes from att#353 have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
@McDutchie McDutchie merged commit ed41611 into ksh93:master Jun 25, 2020
McDutchie pushed a commit that referenced this pull request Jun 25, 2020
Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5
  has been applied to the ksh man page.
- A few fixes from att@5e747cfb
  have been applied to the ksh man page.
- The man page fixes from att#353
  have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
@JohnoKing JohnoKing deleted the minor-fixes branch June 25, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants