Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 18 #1

Merged
merged 2 commits into from
Sep 4, 2017
Merged

Issue 18 #1

merged 2 commits into from
Sep 4, 2017

Conversation

scharlton2
Copy link

Hi Keisuke,

I made a few changes:

  1. set impl->m_isLocked to true where appropriate
  2. updated unittests_cgnsfile for new filelocker

Thanks,
Scott

@scharlton2 scharlton2 mentioned this pull request Sep 1, 2017
Merged
@kskinoue0612
Copy link
Owner

kskinoue0612 commented Sep 1, 2017 via email

@kskinoue0612
Copy link
Owner

Hi Scott,

I've reviewed your commits.
Thanks,

Keisuke

@kskinoue0612 kskinoue0612 merged commit 6b1f4c9 into kskinoue0612:issue-18 Sep 4, 2017
kskinoue0612 pushed a commit that referenced this pull request Mar 11, 2020
@scharlton2
Merge pull request #1 from scharlton2/build_and_release
407b1a5 
Implement appveyor build and create release
kskinoue0612 pushed a commit that referenced this pull request Sep 12, 2021
@scharlton2
Merge pull request #1 from scharlton2/hdf5_export
61f3487 
merge hdf5_export into hdf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scharlton2 @kskinoue0612