Compatibility with Symfony 3.0 and PHP7 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP7 substr() returns an empty string, if the string has exactly the same amount of characters as the provided start position.
|
Thank you, @digilist! |
|
It would be really nice if you tag a new release 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the composer dependency on Symfony to support 3.0. It looks like your library works out of the house with Symfony 3.0. The unit tests are working and I generated a document to test it.
Furthermore, I made a change to support PHP7. Within PHP7, substr() returns an empty string if the length of the input string equals the start position.