Add new registry update command

[shomron]

Part of #237.

Currently supports GitHub repositories only. Helm / Fs support to be added in subsequent PR.

Outstanding issues

• Helm repository support
• Filesystem repository support
• Update to specific version, rather than latest matching
• Tests for TransactionWriter
• Correct update behavior for GitHub repositories lacking a GitVersion section in app.yaml
• Ensure correct consumption of registry caches as part of GitHub registry.yaml cache paths inconsistent #603
• Followup PR for package update

Signed-off-by: Oren Shomron shomron@gmail.com

[shomron]

I'd love some scrutiny around error messages, wrapping semantics.

[coveralls]

Pull Request Test Coverage Report for Build 975

• 132 of 327 (40.37%) changed or added relevant lines in 9 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.7%) to 69.147%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/component/component.go	0	1	0.0%
pkg/app/schema.go	8	10	80.0%
pkg/registry/fs.go	0	3	0.0%
pkg/registry/helm.go	0	3	0.0%
pkg/app/base_app.go	18	26	69.23%
pkg/clicmd/registry_update.go	9	37	24.32%
pkg/registry/github.go	26	90	28.89%
pkg/actions/registry_update.go	67	153	43.79%

Files with Coverage Reduction	New Missed Lines	%
pkg/component/component.go	1	35.79%
pkg/util/strings/rand.go	2	84.62%

Totals
Change from base Build 973:	-0.7%
Covered Lines:	9841
Relevant Lines:	14232

---

💛 - Coveralls

[bryanl]

@shomron

Can you update to a previous SHA1?

$ ks registry update incubator --version=ac9c25c4823037d6e86b0219a3a49b0b7d57ab57 -v             
DEBUG setting log verbosity                         verbosity-level=1
DEBUG loading application configuration from /private/tmp/mule4
DEBUG Updating registries: [incubator]

DEBUG updating registry incubator
DEBUG [github.Update] trying to update registry ksonnet/parts@master
DEBUG [github.Update] current version: 40285d8a14f1ac5787e405e1023cf0c07f6aa28c
DEBUG github: fetching SHA1 for ksonnet/parts@master
DEBUG [fetchRemoteSpec] fetching ksonnet/parts/incubator/registry.yaml@40285d8a14f1ac5787e405e1023cf0c07f6aa28c
DEBUG github: fetching contents for ksonnet/parts/incubator/registry.yaml@40285d8a14f1ac5787e405e1023cf0c07f6aa28c
DEBUG [update] registry incubator version unchanged: 40285d8a14f1ac5787e405e1023cf0c07f6aa28c

[bryanl]

In general, this look fine. I've added a question about upgrading to previous versions.

[bryanl]

No where yet! Wanted to see what this change did first.

[bryanl]

I like this pattern.

[shomron]

Thanks!

[bryanl]

AS for logging, we should start using logrus in a better fashion.

Instead of doing logrus.Debug("[github.Update]: whatever"), why aren't we doing logrus.WithField("action", "github.Update").Debug("whatever"). This would be helpful if you are using ksonnet as part of an automated pipeline because logs would be generated in JSON format and you could actually search for logs with action=github.Update.

[shomron]

Can you update to a previous SHA1?

Not quite yet :) It's in the outstanding issues list above.