KTOR-5560 Add shutdown configuration for engine #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
reviewed
Feb 24, 2023
| @@ -130,6 +130,12 @@ public fun BaseApplicationEngine.Configuration.loadCommonConfiguration(deploymen | |||
| deploymentConfig.propertyOrNull("workerGroupSize")?.getString()?.toInt()?.let { | |||
| workerGroupSize = it | |||
| } | |||
| deploymentConfig.propertyOrNull("shutdownGracePeriod")?.getString()?.toLong()?.let { | |||
| shutdownGracePeriod = it | |||
| } ?: { shutdownGracePeriod = 1000 } | |||
There was a problem hiding this comment.
Could we extract default values to a global constant and use the same value everywhere?
There was a problem hiding this comment.
Thanks, I deleted the setting of default values here because shutdownGracePeriod and shutdownTimeout already have default values in Configuration
e5l
pushed a commit
that referenced
this pull request
Mar 1, 2023
Stexxe
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server
Motivation
KTOR-5560