KTOR-7201 Fix data truncated in receiveParameters and receiveMultipart #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/multipart-field-limit
branch
2 times, most recently
from
be1c844
to
0b9bafa
Compare
bjhham
approved these changes
Jul 18, 2024
Comment on lines
74
to
82
| if (!body.isClosedForRead) { | ||
| body.awaitContent() | ||
| if (!body.isClosedForRead) { | ||
| packet.release() | ||
| val cause = IllegalStateException("Form field size limit exceeded: $formFieldLimit") | ||
| body.cancel(cause) | ||
| throw cause | ||
| } | ||
| } |
There was a problem hiding this comment.
Could introduce an extension method here like body.assertClosedForRead { packet.release(); "Form field size limit exceeded: $formFieldLimit" } to make it a little more declarative and reuseable.
There was a problem hiding this comment.
I'll make suspend fun ByteReadChannel.exhausted(): Boolean instead
e5l
force-pushed
the
e5l/multipart-field-limit
branch
from
0b9bafa
to
c0e9aa6
Compare
e5l
force-pushed
the
e5l/multipart-field-limit
branch
from
375f9ee
to
b9d48ba
Compare
e5l
force-pushed
the
e5l/multipart-field-limit
branch
from
b9d48ba
to
08bfacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-7201 Data truncated in receiveParameters and receiveMultipart