Websockets remove unnecessary memory allocations when trace logging level disabled. #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
requested changes
Sep 6, 2024
Comment on lines
128
to
131
| if (LOGGER.isTraceEnabled) { | ||
| LOGGER.trace( | ||
| "Starting default WebSocketSession($this) " + | ||
| "with negotiated extensions: ${negotiatedExtensions.joinToString()}" | ||
| ) | ||
| } |
There was a problem hiding this comment.
Instead of duplicating the check here, could you please introduce an inline function in ktor-utils/common/src/io/ktor/util/logging/Logger.kt?
/**
* Check `isTraceEnabled` flag before logging to save some memory allocations.
*/
public inline fun Logger.trace(message: () -> String) {
if (isTraceEnabled) trace(message())
}Then we can start replacing our other trace calls with this to save on memory allocations.
berezovik-rs
force-pushed
the
feat/websockets-remove-unnecessary-trace-logs-memory-allocations
branch
from
3fefee0
to
6ee0c82
Compare
berezovik-rs
changed the title
|
Could you please run: And commit the resulting API file changes for ktor-utils prior to merging? |
berezovik-rs
force-pushed
the
feat/websockets-remove-unnecessary-trace-logs-memory-allocations
branch
from
6ee0c82
to
f178842
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Websockets remove unnecessary memory allocations when trace logging level disabled.
Subsystem
Server websockets
Motivation
Unnecessary memory allocations if log level > TRACE
Solution
Add inline function with isTraceEnabled flag check