allow setting tcell prompt color #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd originally opened this as #13 ages ago, back before this library updated to tcell.
I picked it up again while updating dependencies in my fork.
In the original PR, we'd talked about encapsulating the set of colors in go-fuzzyfinder to avoid leaking the underlying terminal library through to the option struct. Looking at tcell, I'm not sure I see a way to cleanly do that. Because tcell is basically taking a uint64, and is itself already supporting any standard / xterm color, the set of colors it accepts is massive. I could make the function take a uint64 and cast it, but that doesn't actually feel cleaner: I'd be leaking tcell's methodology but in a less clear way.
Curious for your thoughts.