Add git diff stat to resolve issue 142 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add-git-diff-to-resolve-issue-142
ktrysmt
approved these changes
Jul 5, 2021
Closed
DataDavD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the GetDiffStat function as well as its corresponding test.
The new function currently just returns the DiffStatRes object that includes the DiffStats object which is a slice of DiffStat's. The DiffStats are the "values" returned by the Bitbucket 2.0 API.
@ktrysmt my tests pass successfully, but for some reason I couldn't get the Docker/Swagger tests to pass; it kept saying the Bitbucket env variables were empty. If this is resolved I can rerun this part of the test.
FYI: in I had to tweak the
TestCreateBranchRestrictionsKindPushandTestCreateBranchRestrictionsKindRequirePassingBuildstests in order to get the test suite build to run the diff tests. The tweaks I made will be in another PR that I will submit soon.Thank you for letting me contribute to this wonderful go package. I hope to contribute even more!!!!