Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resizable viewport #19

Merged
merged 10 commits into from
Apr 5, 2018
Merged

feat: resizable viewport #19

merged 10 commits into from
Apr 5, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Mar 26, 2018

It does not have any styles yet. I'll add them later.

@codecov
Copy link

codecov bot commented Apr 3, 2018

Codecov Report

Merging #19 into master will increase coverage by 1.16%.
The diff coverage is 68.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   63.48%   64.64%   +1.16%     
==========================================
  Files          41       44       +3     
  Lines        1320     1355      +35     
  Branches      314      324      +10     
==========================================
+ Hits          838      876      +38     
+ Misses        467      464       -3     
  Partials       15       15
Impacted Files Coverage Δ
src/view/App.vue 0% <ø> (ø) ⬆️
src/view/components/PageMain.vue 0% <0%> (ø) ⬆️
src/view/store/modules/viewport.ts 0% <0%> (ø)
src/view/components/Viewport.vue 0% <0%> (ø) ⬆️
src/view/components/Renderer.vue 0% <0%> (ø) ⬆️
src/view/store/modules/index.ts 0% <0%> (ø) ⬆️
src/view/components/Resizable.vue 100% <100%> (ø)
src/view/store/modules/project.ts 47.26% <100%> (+7.67%) ⬆️
src/view/components/Toolbar.vue 90% <90%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca762b...825a2d9. Read the comment docs.

@ktsn
Copy link
Owner Author

ktsn commented Apr 3, 2018

TODO: add a toolbar for the users can see the current viewport size.

@ktsn ktsn changed the title [WIP] feat: resizable viewport feat: resizable viewport Apr 4, 2018
@ktsn
Copy link
Owner Author

ktsn commented Apr 5, 2018

viewport-resize

@ktsn ktsn merged commit 98bd2fe into master Apr 5, 2018
@ktsn ktsn deleted the resizable-viewport branch April 5, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant