Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/subprocess #28

Merged
merged 4 commits into from
May 10, 2021
Merged

Fix/subprocess #28

merged 4 commits into from
May 10, 2021

Conversation

tamuhey
Copy link
Contributor

@tamuhey tamuhey commented May 28, 2020

process.Subprocess used signal to set timeout for subprocess, but because of this some features couldn't be used with multithreading.

In this PR, I fixed this problem by replacing the signal with timeout parameter of subprocess.run.

@meokz
Copy link

meokz commented Feb 20, 2021

I have observed a similar problem under multithreading. Resolving the conflicts was easy.

Why can't you consider this PR merge?

@nobu-g nobu-g merged commit 82b4e56 into ku-nlp:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants