Add open-ended rake dependency #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mattrayner. I'll be releasing rainbow v3.0 very soon, which doesn't have this problem (it doesn't have native ext, doesn't require rake). We're discussing it here: #46 (comment) |
|
Thanks! Releasing 2.2.2 with this patch right now. |
|
Thanks Marcin Kulik :-)
…On Fri, 21 Apr 2017 at 14:00 Marcin Kulik ***@***.***> wrote:
Thanks! Releasing 2.2.2 with this patch right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADVzNlVLc6jtmZplMT9SkcfaCcerO-sZks5ryKhagaJpZM4M4sYg>
.
|
|
Any update on when rainbow 3.x will be released? |
|
@ioquatix Could you use |
|
It fixes it for me 👍🏻
…On Wed, 11 Oct 2017 at 08:14 Marcin Kulik ***@***.***> wrote:
@ioquatix <https://github.com/ioquatix> Could you use gem "rainbow",
github:"sickill/rainbow"` in your Gemfile, and check if all is good? I
haven't had time to test this and unfortunately also haven't heard from
people whether current master version solves all the rake/installation
problems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADVzNgN7rgLh02h05lzklEa-V2XOs43Lks5srGrpgaJpZM4M4sYg>
.
|
|
Can you release this as 2.3? |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to address [#57] I have added an open-ended Rake dependency to this gem. Currently when building in environments such as Ubuntu or Alpine linux with applications such as Sinatra (that do not require rake) any gem including Rainbow will cause bundler to fail.
We may want to look at what version of Rake you really require. But in the meantime, a dependency on Rake should be added to the gemspec ASAP