Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: RVM note, extract env, cache bundler right; Appveyor: fix build #75

Merged
merged 3 commits into from Nov 13, 2017
Merged

Travis: RVM note, extract env, cache bundler right; Appveyor: fix build #75

merged 3 commits into from Nov 13, 2017

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Nov 13, 2017 •
edited

This tiny change fixes three five things:

Travis

  • speed: RVM does gem update --system on its own
  • readability: configure JRUBY_OPTS as env global
  • clarity: Travis YAML config cache shorthand for bundler corrected
  • update: use latest JRuby in CI matrix - jruby-9.1.14.0

Appveyor

@olleolleolle
Travis: RVM note, extract env, cache bundler right
0f1903d 
  - RVM does gem update --system on its own
  - put JRUBY_OPTS as env global
  - cache shorthand for bundler corrected
@olleolleolle olleolleolle self-assigned this Nov 13, 2017
@olleolleolle olleolleolle changed the title Travis: RVM note, extract env, cache bundler right Travis: RVM note, extract env, cache bundler right; Appveyor: fix build Nov 13, 2017
@olleolleolle
Copy link
Collaborator Author

@sickill If this runs green, I'll merge it.

ku1ik
ku1ik approved these changes Nov 13, 2017
View reviewed changes
Copy link
Owner

@ku1ik ku1ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's merge it when build finishes. 👍

@olleolleolle olleolleolle merged commit e67d4fe into master Nov 13, 2017
@olleolleolle olleolleolle deleted the fix/travis-gem-update-included branch November 13, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ku1ik ku1ik ku1ik approved these changes

Assignees

@olleolleolle olleolleolle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olleolleolle @ku1ik