Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue related to Employee and non-employee search
|
What part of this change is code we introduced and what part is copied? |
|
@leoherbie Rice LightTable is copied to KcLightTable and performFinalize method is modified |
leoherbie
added a commit
that referenced
this pull request
Dec 29, 2014
|
So we copied all of light table from Rice just to modify a single method? Is there a reason we didn't just extend and override? Same with the light table DD override? Are all those property definitions new? |
KualiCoSaaSOps
pushed a commit
that referenced
this pull request
Jan 29, 2016
Revert "updating plugins and dependencies #norelease"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KRACOEUS-8607
Fix issue related to Employee and non-employee search
This fix works both in PD (multiple results returned based on wild card search) and returning multiple results in budget persons.
There is an issue with KRAD Light table where it binds only the first result based on search criteria. So only the first result will be returned if selected, otherwise no results are returned on a multi select search result based on search criteria. It works as expected in table collection.
Light table gives a better performance on searches with limited functionalities when compared to Table collection.
As per conversation with Brian, overriding Light table in KC until we get this fixed in rice.
Created a rice jira KULRICE-14122