workflow: add clippy and cargo-deny linters #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a GitHub workflow that performs clippy linting and cargo-deny auditing on Rust code. Fixes kuasar-io#12
8 tasks
dierbei
force-pushed
the
lint
branch
6 times, most recently
from
4824971
to
cbd55e0
Compare
|
Clippy error fixed. |
Burning1020
reviewed
May 29, 2023
| @@ -205,7 +205,7 @@ impl KuasarFactory { | |||
| // pivot_root could not work with initramfs | |||
| match get_mount_type("/") { | |||
| Ok(m_type) => { | |||
| if m_type == "rootfs".to_string() { | |||
| if m_type == *"rootfs" { | |||
There was a problem hiding this comment.
- Efficiency: the second approach is more efficient. Dereferencing string literal to &str types requires no additional memory allocation or replication.
- Code brevity: the second approach is more concise, with no unnecessary method calls and type conversions.
Burning1020
reviewed
May 30, 2023
Vanient
requested changes
May 31, 2023
| .vhost(false) | ||
| .vhostfds(vec![]) | ||
| .bus(Some(DEFAULT_PCIE_BUS.to_string())) | ||
| .build(); |
There was a problem hiding this comment.
the benefits of new one is reducing input params or else?
There was a problem hiding this comment.
Yes, clippy recommends not having too many parameters.
So I try to reduce the argument of the function.
There was a problem hiding this comment.
Signed-off-by: dierbei <1628652790@qq.com>
|
/lgtm |
Vanient
approved these changes
Jun 2, 2023
Vanient
approved these changes
Jun 2, 2023
Vanient
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a GitHub workflow that performs clippy linting and cargo-deny auditing on Rust code.
Fixes #12