Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept wchars for MKDIR #200

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Accept wchars for MKDIR #200

merged 3 commits into from
Jul 22, 2021

Conversation

kuba--
Copy link
Owner

@kuba-- kuba-- commented Jul 22, 2021

No description provided.

@kuba-- kuba-- marked this pull request as draft July 22, 2021 09:18
@kuba-- kuba-- added the windows related to windows OS label Jul 22, 2021
@kuba-- kuba-- marked this pull request as ready for review July 22, 2021 09:21
@UAchar
Copy link

UAchar commented Jul 22, 2021

Yes It is working fine for wchar characters now! Thanks a lot for the quick update and setting the label after this merge!

Before setting the label, Could you please change the initialization in line 426 in zip.c to mz_uint64 d_pos = ~0ul;
I would like to work with /Wx and avoid warnings all together!

@kuba--
Copy link
Owner Author

kuba-- commented Jul 22, 2021

Yes It is working fine for wchar characters now! Thanks a lot for the quick update and setting the label after this merge!

Before setting the label, Could you please change the initialization in line 426 in zip.c to mz_uint64 d_pos = ~0ul;
I would like to work with /Wx and avoid warnings all together!

done.

@kuba-- kuba-- merged commit e6f08d4 into master Jul 22, 2021
@kuba-- kuba-- deleted the mz_mkdir branch July 22, 2021 10:26
thabetx pushed a commit to Symbyo360/zip that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows related to windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants