Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch configmap ingress ngnix controller for minkube #111

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

Adir111
Copy link
Contributor

@Adir111 Adir111 commented Jul 11, 2024

Related to the following PR: #110
Related Issue: kube-HPC/hkube#1919

According to the instructions page for hkube, the command for installation is:
helm install hkube --set build_secret.docker_registry=registry.minikube --set build_secret.docker_registry_insecure=true hkube/hkube

Therefore, there is no need to run the previous command:
helm install hkube my-chart --set isMinikube=true

This is because Minikube is already defined in the value build_secret.docker_registry.


Additionally, during the installation of the Helm chart, we receive the following warnings:
W0711 15:43:06.897997 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:06.898590 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.205250 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.487973 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.589177 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.602282 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.694055 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead W0711 15:43:07.694163 1291784 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

These warnings have been addressed to prevent potential issues in future Kubernetes releases.


This change is Reviewable

@Adir111 Adir111 self-assigned this Jul 11, 2024
@Adir111 Adir111 requested a review from golanha July 11, 2024 13:23
@Adir111 Adir111 merged commit cc1a7da into master Jul 11, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
…ontroller_for_minkube

Updated: Patch configmap ingress ngnix controller for minkube
Handled Warnings as well. .... bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant