add support for standard Condition APIs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
k8s-openapi-condition
branch
from
3000a1c
to
5c2ffb0
Compare
|
wow, this is a huge change. it passes tests which is a great sign! thanks a lot. going to try to cross-reference the code with |
clux
reviewed
Mar 7, 2024
|
if you don't mind i'll push a commit on top of this |
|
added |
aryan9600
force-pushed
the
k8s-openapi-condition
branch
from
5c2ffb0
to
e09369f
Compare
|
needs a |
Detect the presence of a Conditions object in a schema and use `k8s_openapi::apimachinery::pkg::apis::meta::v1::Condition` if present. Introduce a new flag `--no-condition` which allows revering back to the old behavior of generating a custom Condition API for each instance. Furthermore, introduce `analyzer::Config` which allows for customizing the behavior of the `analyze` function. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com> Co-authored-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
aryan9600
force-pushed
the
k8s-openapi-condition
branch
from
e09369f
to
d38d84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the presence of a Conditions object in a schema and use
k8s_openapi::apimachinery::pkg::apis::meta::v1::Conditionif present. Introduce a new flag--no-conditionwhich allows revering back to the old behavior of generating a custom Condition API for each instance.Furthermore, introduce
analyzer::Configwhich allows for customizing the behavior of theanalyzefunction.Fixes #199