-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for standard Condition APIs #203
Conversation
3000a1c
to
5c2ffb0
Compare
wow, this is a huge change. it passes tests which is a great sign! thanks a lot. going to try to cross-reference the code with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, and a suggestion that might avoid the indent
if you don't mind i'll push a commit on top of this |
added |
5c2ffb0
to
e09369f
Compare
needs a |
Detect the presence of a Conditions object in a schema and use `k8s_openapi::apimachinery::pkg::apis::meta::v1::Condition` if present. Introduce a new flag `--no-condition` which allows revering back to the old behavior of generating a custom Condition API for each instance. Furthermore, introduce `analyzer::Config` which allows for customizing the behavior of the `analyze` function. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com> Co-authored-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
e09369f
to
d38d84e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Detect the presence of a Conditions object in a schema and use
k8s_openapi::apimachinery::pkg::apis::meta::v1::Condition
if present. Introduce a new flag--no-condition
which allows revering back to the old behavior of generating a custom Condition API for each instance.Furthermore, introduce
analyzer::Config
which allows for customizing the behavior of theanalyze
function.Fixes #199