Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend watchevent with bookmark type #54

Closed
clux opened this issue Jul 27, 2019 · 1 comment
Closed

extend watchevent with bookmark type #54

clux opened this issue Jul 27, 2019 · 1 comment
Assignees
Labels
api Api abstraction related

Comments

@clux
Copy link
Member

clux commented Jul 27, 2019

a 1.15ism. See https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190206-watch-bookmark.md

@clux
Copy link
Member Author

clux commented Nov 23, 2019

This is now beta in 1.16 and better documented in https://kubernetes.io/docs/reference/using-api/api-concepts/#watch-bookmarks

Probably just extending the WatchEvent and adding in the flag to the query params. I'm guessing it's ignored if it's not supported, but it should probably be user controlled somehow. Maybe via the reflector / informer Params struct.

@clux clux added enhancement good first issue Good for newcomers help wanted Not immediately prioritised, please help! labels Nov 23, 2019
@clux clux added api Api abstraction related and removed enhancement labels Feb 26, 2020
@clux clux removed good first issue Good for newcomers help wanted Not immediately prioritised, please help! labels Apr 7, 2020
@clux clux self-assigned this Apr 7, 2020
clux added a commit that referenced this issue Apr 7, 2020
@clux clux closed this as completed in 610d89b Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Api abstraction related
Projects
None yet
Development

No branches or pull requests

1 participant