Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dyntype from ObjectRef #1053

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Remove dyntype from ObjectRef #1053

wants to merge 18 commits into from

Commits on Dec 12, 2022

  1. Remove dyntype concerns from ObjectRef 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    d53ef44 View commit details
    Browse the repository at this point in the history

  2. Add a runtime TypeInfo trait to avoid dealing with DynamicType 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a84e98f View commit details
    Browse the repository at this point in the history

  3. most lint errors 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ba08ed0 View commit details
    Browse the repository at this point in the history

  4. avoid potential obscure edge case unwrap 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    fea6c70 View commit details
    Browse the repository at this point in the history

  5. reinstate ObjectRef -> ObjectReference in form of a TryFrom 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    fc2abd4 View commit details
    Browse the repository at this point in the history

  6. minor feedback points 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    38458e0 View commit details
    Browse the repository at this point in the history

  7. TypeInfo trait now returns Option<Cow> rather than Option<String> 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    05b8540 View commit details
    Browse the repository at this point in the history

  8. fix kube-derive impl 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6428341 View commit details
    Browse the repository at this point in the history

  9. accidentally omitted lifetimes 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    46d72dd View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into dyn-lift

    @clux
    clux authored Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b6025ce View commit details
    Browse the repository at this point in the history

  11. use typeinfo from OwnerReference when possible 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7051f3f View commit details
    Browse the repository at this point in the history

  12. use ownerreference info when using trigger_owners 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4f4c9a0 View commit details
    Browse the repository at this point in the history

  13. make all ObjectRef constructors require type info by default 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8f0376d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. rename TypeInfo to Inspect 

    more accurately explains what the trait is doing

Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e58a6a7 View commit details
    Browse the repository at this point in the history

  2. clippy 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    d6ea7a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Merge branch 'main' into dyn-lift 

    Signed-off-by: Eirik A <sszynrae@gmail.com>
    @clux
    clux authored Dec 18, 2022
    Configuration menu
    Copy the full SHA
    931d462 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Merge branch 'main' into dyn-lift 

    Signed-off-by: Eirik A <sszynrae@gmail.com>
    @clux
    clux authored Feb 12, 2023
    Configuration menu
    Copy the full SHA
    25cb9dd View commit details
    Browse the repository at this point in the history

  2. fmt + fix wrong merge conflict resolution 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    d031950 View commit details
    Browse the repository at this point in the history